[PATCH v2 1/4] dt-bindings: i2c: add support for AE350 I2C controller
Krzysztof Kozlowski
krzk at kernel.org
Thu Jan 22 01:50:03 PST 2026
On 22/01/2026 09:08, Krzysztof Kozlowski wrote:
>> +properties:
>> + compatible:
>> + oneOf:
>> + - items:
>> + - enum:
>> + - andestech,qilai-i2c
>> + - const: andestech,ae350-i2c
>> + - const: andestech,ae350-i2c
>
> Same question as before. Nothing in commit msg explains me above and you
> STILL DID NOT send your soc upstream which would help me to understand
To clarify: no top-level bindings for `git grep andestech,ae350`
> the relation between SoCs.
>
> Considering you did not even build check previous version, I do not give
> you any benefits of the doubt that this is correct code.
>
> Respond to previous review.
>
> That is a NAK and I am dropping it from the patchwork.
Best regards,
Krzysztof
More information about the linux-riscv
mailing list