[PATCH v2 1/4] dt-bindings: i2c: add support for AE350 I2C controller
Krzysztof Kozlowski
krzk at kernel.org
Thu Jan 22 00:08:40 PST 2026
On Thu, Jan 22, 2026 at 11:53:18AM +0800, Ben Zong-You Xie wrote:
> Document device tree bindings for the I2C controller on Andes AE350
> platform.
>
> Signed-off-by: Ben Zong-You Xie <ben717 at andestech.com>
> ---
> .../bindings/i2c/andestech,ae350-i2c.yaml | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/andestech,ae350-i2c.yaml b/Documentation/devicetree/bindings/i2c/andestech,ae350-i2c.yaml
> new file mode 100644
> index 000000000000..59a521fb249b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/andestech,ae350-i2c.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/andestech,ae350-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Andes I2C controller on AE350 platform
> +
> +maintainers:
> + - Ben Zong-You Xie <ben717 at andestech.com>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - andestech,qilai-i2c
> + - const: andestech,ae350-i2c
> + - const: andestech,ae350-i2c
Same question as before. Nothing in commit msg explains me above and you
STILL DID NOT send your soc upstream which would help me to understand
the relation between SoCs.
Considering you did not even build check previous version, I do not give
you any benefits of the doubt that this is correct code.
Respond to previous review.
That is a NAK and I am dropping it from the patchwork.
Best regards,
Krzysztof
More information about the linux-riscv
mailing list