[PATCH v1] gpio: mpfs: fix setting gpio direction to output
Conor Dooley
conor at kernel.org
Fri Sep 26 04:20:37 PDT 2025
On Fri, Sep 26, 2025 at 11:57:30AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
>
>
> On Thu, 25 Sep 2025 16:39:18 +0100, Conor Dooley wrote:
> > mpfs_gpio_direction_output() actually sets the line to input mode.
> > Use the correct register settings for output mode so that this function
> > actually works as intended.
> >
> > This was a copy-paste mistake made when converting to regmap during the
> > driver submission process. It went unnoticed because my test for output
> > mode is toggling LEDs on an Icicle kit which functions with the
> > incorrect code. The internal reporter has yet to test the patch, but on
> > their system the incorrect setting may be the reason for failures to
> > drive the GPIO lines on the BeagleV-fire board.
> >
> > [...]
>
> I'm about to send my last PR with fixes for v6.17 and this hasn't been
> in next even for a day so let me queue this for v6.18 and it will get
> backported once it's upstream next week.
Ye, that's not a problem. It's an "always been broken" thing, so no real
rush. Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20250926/de97a637/attachment.sig>
More information about the linux-riscv
mailing list