[PATCH v1] gpio: mpfs: fix setting gpio direction to output
Bartosz Golaszewski
brgl at bgdev.pl
Fri Sep 26 02:57:30 PDT 2025
From: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
On Thu, 25 Sep 2025 16:39:18 +0100, Conor Dooley wrote:
> mpfs_gpio_direction_output() actually sets the line to input mode.
> Use the correct register settings for output mode so that this function
> actually works as intended.
>
> This was a copy-paste mistake made when converting to regmap during the
> driver submission process. It went unnoticed because my test for output
> mode is toggling LEDs on an Icicle kit which functions with the
> incorrect code. The internal reporter has yet to test the patch, but on
> their system the incorrect setting may be the reason for failures to
> drive the GPIO lines on the BeagleV-fire board.
>
> [...]
I'm about to send my last PR with fixes for v6.17 and this hasn't been
in next even for a day so let me queue this for v6.18 and it will get
backported once it's upstream next week.
[1/1] gpio: mpfs: fix setting gpio direction to output
https://git.kernel.org/brgl/linux/c/bc061143637532c08d9fc657eec93fdc2588068e
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
More information about the linux-riscv
mailing list