[PATCH v2 6/9] dt-bindings: cache: ax45mp-cache: allow variable cache-sets for Andes L2 cache

Conor Dooley conor at kernel.org
Fri May 9 07:57:36 PDT 2025


On Tue, May 06, 2025 at 05:23:21PM +0100, Conor Dooley wrote:
> On Sat, May 03, 2025 at 11:18:26PM +0800, Ben Zong-You Xie wrote:
> > The current device tree binding for the Andes AX45MP L2 cache enforces
> > a fixed number of cache-sets (1024). However, there are 2048 cache-sets in
> > the QiLai SoC. This change allows both 1024 and 2048 as valid values for
> > "cache-sets".
> > 
> > Signed-off-by: Ben Zong-You Xie <ben717 at andestech.com>
> > Acked-by: Rob Herring (Arm) <robh at kernel.org>
> 
> Applied, thanks.

You know what, I am starting to have second thoughts here. Why does the
qilai not have a specific compatible like the plic etc? I think you
should have one, and only allow the 2048 cache-sets there. I'm going to
go and drop this patch, and please do that for the next version.

Prabhakar, should we add a specific one for the rz/five too?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20250509/598fd891/attachment.sig>


More information about the linux-riscv mailing list