[PATCH] riscv: config: Set MEDIA_SUPPORT_FILTER

[Joel Stanley]

On Tue, 15 Apr 2025 at 18:32, Alexandre Ghiti <alex at ghiti.fr> wrote:
>
> Hi Joel,
>
> On 04/04/2025 08:22, Joel Stanley wrote:
> > When Hal enabled MEIDA_SUPPORT in order to add the VIDEO_CADENCE_CSI2RX
> > driver in commit d8a7d89abb09 ("riscv: defconfig: Enable StarFive JH7110
> > drivers"), it turned on a few hundred (254) other MEDIA drivers.
> >
> > The subsystem has a option for this very case that keeps the other
> > drivers disabled: MEDIA_SUPPORT_FILTER. Turn that on, and
> > MEDIA_PLATFORM_SUPPORT, so the CSI2RX driver stays enabled.
> >
> > Signed-off-by: Joel Stanley <joel at jms.id.au>
> > ---
> > The filter option only appears in a small handful of arm32 defconfigs
> > (and I maintain a few of them). That's because MEDIA_SUPPORT_FILTER is
> > normally enabled unless EXPERT is on.
> >
> > The root of the issue is the riscv defconfig selects EXPERT. Most
> > arch-wide defconfig don't have that on. Need to get to the bottom of
> > that, and perhaps disable EXPERT?
>
>
> I could not find the specific reason why we enabled EXPERT in defconfig.
> Given the description of this config
> (https://elixir.bootlin.com/linux/v6.14-rc6/source/init/Kconfig#L1545),
> I think it should be removed from defconfig instead, that will fix the
> "issue" your uncovered here and maybe others?

Yeah, I agree. I've prepared a patch that removes EXPERT with some
commentary on the fallout. I'll send that now as a replacement for
this patch.

Cheers,

Joel