[PATCH] riscv: config: Set MEDIA_SUPPORT_FILTER

[Alexandre Ghiti]

Hi Joel,

On 04/04/2025 08:22, Joel Stanley wrote:
> When Hal enabled MEIDA_SUPPORT in order to add the VIDEO_CADENCE_CSI2RX
> driver in commit d8a7d89abb09 ("riscv: defconfig: Enable StarFive JH7110
> drivers"), it turned on a few hundred (254) other MEDIA drivers.
>
> The subsystem has a option for this very case that keeps the other
> drivers disabled: MEDIA_SUPPORT_FILTER. Turn that on, and
> MEDIA_PLATFORM_SUPPORT, so the CSI2RX driver stays enabled.
>
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
> The filter option only appears in a small handful of arm32 defconfigs
> (and I maintain a few of them). That's because MEDIA_SUPPORT_FILTER is
> normally enabled unless EXPERT is on.
>
> The root of the issue is the riscv defconfig selects EXPERT. Most
> arch-wide defconfig don't have that on. Need to get to the bottom of
> that, and perhaps disable EXPERT?


I could not find the specific reason why we enabled EXPERT in defconfig. 
Given the description of this config 
(https://elixir.bootlin.com/linux/v6.14-rc6/source/init/Kconfig#L1545), 
I think it should be removed from defconfig instead, that will fix the 
"issue" your uncovered here and maybe others?

Let me know what you think,

Thanks,

Alex


>
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>   arch/riscv/configs/defconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index 0f7dcbe3c45b..c34fcf2c6a2f 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -182,6 +182,8 @@ CONFIG_REGULATOR_FIXED_VOLTAGE=y
>   CONFIG_REGULATOR_AXP20X=y
>   CONFIG_REGULATOR_GPIO=y
>   CONFIG_MEDIA_SUPPORT=m
> +CONFIG_MEDIA_SUPPORT_FILTER=y
> +CONFIG_MEDIA_PLATFORM_SUPPORT=y
>   CONFIG_VIDEO_CADENCE_CSI2RX=m
>   CONFIG_DRM=m
>   CONFIG_DRM_RADEON=m