[PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes

Aurelien Jarno aurelien at aurel32.net
Wed Oct 16 22:42:12 PDT 2024


Hi,

On 2024-10-16 21:11, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley at microchip.com>
> 
> Aurelien reported probe failures due to the csi node being enabled
> without having a camera attached to it. A camera was in the initial
> submissions, but was removed from the dts, as it had not actually been
> present on the board, but was from an addon board used by the
> developer of the relevant drivers. The non-camera pipeline nodes were
> not disabled when this happened and the probe failures are problematic
> for Debian. Disable them.
> 
> CC: stable at vger.kernel.org
> Fixes: 28ecaaa5af192 ("riscv: dts: starfive: jh7110: Add camera subsystem nodes")
> Closes: https://lore.kernel.org/all/Zw1-vcN4CoVkfLjU@aurel32.net/
> Reported-by: Aurelien Jarno <aurelien at aurel32.net>
> Signed-off-by: Conor Dooley <conor.dooley at microchip.com>
> ---
> CC: Emil Renner Berthing <kernel at esmil.dk>
> CC: Rob Herring <robh at kernel.org>
> CC: Krzysztof Kozlowski <krzk+dt at kernel.org>
> CC: Conor Dooley <conor+dt at kernel.org>
> CC: Changhuang Liang <changhuang.liang at starfivetech.com>
> CC: devicetree at vger.kernel.org
> CC: linux-riscv at lists.infradead.org
> CC: linux-kernel at vger.kernel.org
> ---
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 --
>  1 file changed, 2 deletions(-)

Thanks for picking up that issue. I confirm this fix the "problem".

To give some more details, the problem for Debian is that it appears as
an error, with the line in red in dmesg or journalctl. However we would
like to be able to provide a kernel with such drivers enabled so that
users with a camera can just use an overlay or patch their device tree.

Tested-by: Aurelien Jarno <aurelien at aurel32.net>
Reviewed-by: Aurelien Jarno <aurelien at aurel32.net>

Regards
Aurelien
 

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net



More information about the linux-riscv mailing list