[PATCH v3 2/4] riscv: dts: starfive: enable heartbeat LED for Milk-V Mars

[FUKAUMI Naoki]

Hi

On 7/1/24 21:28, Emil Renner Berthing wrote:
(snip)
> Hi Naoki
> 
> Thanks for adding the other boards too. As mentioned previously [1] boards
> should not add functions to LEDs unless the hardware clearly defines a function
> for them, and nothing on these boards mention that it should be a heartbeeat.
> As you said on IRC userland can easily add whatever function they want.

on behalf of MilkV Technology, what should we do to add function to LED?

I think even if hardware clearly defines a function, you'll say userland 
can easily do it. any objections?

--
FUKAUMI Naoki
Shenzhen MilkV Technology Co., Ltd.

> 
> Also please add a cover letter when you're sending multiple patches.
> Eg. use git format-patch --cover-letter
> 
> /Emil
> 
> [1]: https://lore.kernel.org/linux-riscv/CAJM55Z_j8gWFyKvsiu-oGDV7Hacr4Amt5FdkHdjKnhZwZgxncA@mail.gmail.com/
> 
>>   };
>>
>>   &gmac0 {
>> --
>> 2.43.0
>>
>