[PATCH v2 1/3] riscv: Improve PTDUMP to show RSW with non-zero value

Yu-Chien Peter Lin peterlin at andestech.com
Tue Sep 19 20:17:36 PDT 2023


On Mon, Sep 18, 2023 at 01:53:13PM +0100, Conor Dooley wrote:
> On Thu, Sep 14, 2023 at 09:40:25AM +0800, Yu Chien Peter Lin wrote:
> 
> > +		val = st->current_prot & pte_bits[i].mask;
> > +		if (val) {
> > +			if (pte_bits[i].mask == _PAGE_SOFT)
> > +				sprintf(s, pte_bits[i].set, val >> 8);
> > +			else
> > +				sprintf(s, "%s", pte_bits[i].set);
> > +		} else
> > +			sprintf(s, "%s", pte_bits[i].clear);
> > +
> 
> just a nit, but checkpatch in the automation is whinging that you have
> forgotten to add {} around both branches if this if statement.

Hi Conor,

Will fix the warning.

Thanks,
Peter Lin



More information about the linux-riscv mailing list