[PATCH 13/20] reset: remove MODULE_LICENSE in non-modules

Conor Dooley conor at kernel.org
Tue Feb 28 11:17:39 PST 2023


On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof at kernel.org>
> Cc: Luis Chamberlain <mcgrof at kernel.org>
> Cc: linux-modules at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi at fujitsu.com>
> Cc: Conor Dooley <conor.dooley at microchip.com>
> Cc: Daire McNamara <daire.mcnamara at microchip.com>
> Cc: Philipp Zabel <p.zabel at pengutronix.de>
> Cc: linux-riscv at lists.infradead.org
> ---
>  drivers/reset/reset-mpfs.c | 1 -

I assume your script just got confused here w/ $subject, since there's
only a change for this specific file.
Reviewed-by: Conor Dooley <conor.dooley at microchip.com>

Thanks,
Conor.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230228/74c6f579/attachment.sig>


More information about the linux-riscv mailing list