[PATCH 7/7] pwm: sifive: Shut down hardware only after pwmchip_remove() completed

Conor.Dooley at microchip.com Conor.Dooley at microchip.com
Thu Jul 28 10:45:40 PDT 2022


On 28/07/2022 18:12, Thierry Reding wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Jul 22, 2022 at 07:45:32PM +0200, Emil Renner Berthing wrote:
>> On Thu, 21 Jul 2022 at 12:32, Uwe Kleine-König
>> <u.kleine-koenig at pengutronix.de> wrote:
>>> The PWMs are expected to be functional until pwmchip_remove() is called.
>>> So disable the clks only afterwards.
>>>
>>> Fixes: 9e37a53eb051 ("pwm: sifive: Add a driver for SiFive SoC PWM")
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>>
>> Hi Uwe,
>>
>> You didn't send a cover letter so unsure which mail to respond to, but
>> I tested this series with
>>
>> https://lore.kernel.org/linux-riscv/20220705210143.315151-1-emil.renner.berthing@canonical.com/
>>
>> ..and everything keeps working, so
>>
>> Tested-by: Emil Renner Berhing <emil.renner.berthing at canonical.com>
                             ^
Pretty minor I guess, but that should be "Berthing"

> 
> This is fine, I've applied the tag to the whole series since you said
> that you had tested the whole series. I'm not sure, but I don't think
> patchwork automatically adds tags to all patches if they are given to
> the cover letter, so in those cases a bit of manual intervention can
> be necessary. Perhaps b4 can do this automatically. I should probably
> test that at some point.

The -t flag for b4 am will do it automatically for tags applied to the
cove. In fact it prompts you if you don't pass -t and the cover has
tags.

Thanks,
Conor.


More information about the linux-riscv mailing list