[PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y

Conor.Dooley at microchip.com Conor.Dooley at microchip.com
Tue Jul 19 03:38:30 PDT 2022


On 19/07/2022 11:35, Guo Ren wrote:
> On Tue, Jul 19, 2022 at 6:29 PM <Conor.Dooley at microchip.com> wrote:
>>
>> On 19/07/2022 11:15, Guo Ren wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> Sorry, I missed your patch. You are the first person to catch that.
>>>
>>> + $(build)=arch/riscv/kernel/compat_vdso compat_$@)
>>>
>>> The above is also good for me.
>>>
>>> For that one, Could you add "Fixes: 0715372a06ce ("riscv: compat:
>>> vdso: Add COMPAT_VDSO base code ...")" in your next version of the
>>> patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
>>>
>>>
>>
>> Why would Ben get a Co-developed-by?
> 
> Just a suggestion to "Emil Renner Berthing".
> 
> My reason is:
> 1. I think the "Fixes:" is also necessary, and Emil could directly use
> it from Ben's patch.
> 2. He also found that problem and shared the information with us. The
> key effect is to make Emil's patch quickly reviewed (Although I missed
> that patch).

Tbh, I don't think either of those would result in a Co-developed-by.

Reported-by: would be more accurate, no?

Thanks,
Conor.



More information about the linux-riscv mailing list