[PATCH v2 1/4] riscv, mm: detect svnapot cpu support at runtime

[潘庆霖]

> On 16/07/2022 13:35, Jisheng Zhang wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Sat, Jul 16, 2022 at 04:56:45PM +0800, panqinglin2020 at iscas.ac.cn wrote:
> >> From: Qinglin Pan <panqinglin2020 at iscas.ac.cn>
> >>
> >> This patch add two erratas to enable/disable svnapot support, patches code
> >> dynamicly when "svnapot" is in the "riscv,isa" field of fdt and SVNAPOT compile
> >> option is set. It will influence the behavior of has_svnapot function and
> >> pte_pfn function. All code dependent on svnapot should make sure that has_svnapot
> >> return true firstly.
> >>
> >> Also, this patch modifies PTE definition for Svnapot, and creates some functions in
> >> pgtable.h to mark a PTE as napot and check if it is a Svnapot PTE.
> >> Until now, only 64KB napot size is supported in draft spec, so some macros
> >> has only 64KB version.
> >>
> >> Yours,
> >> Qinglin
> > 
> > hmm, this "Yours ..." should be removed in commit msg
> 
> And while they're at it, they can drop the "This patch".
> 
> I might've said this on a v1 (I know I said it on someone's
> v1 recently) that having "Also, this patch" makes it sound
> like this should actually be two patches and not one.
> 
> Thanks,
> Conor.
> 

Thanks for the hints, will do in a newer version patch.


Thanks,
Qinglin.</panqinglin2020 at iscas.ac.cn>