[PATCH 1/4] dt-bindings: PCI: fu740-pci: fix missing clock-names
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri Aug 12 00:34:40 PDT 2022
On 11/08/2022 23:33, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley at microchip.com>
>
> The commit in the fixes tag removed the clock-names property from the
Instead:
The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix
'unevaluatedProperties' warnings")....
> SiFive FU740 PCI Controller dt-binding,
No, it did not do it... At least I cannot see it. Where is the removal
exactly in that patch? The commit removed clock-names from required, not
from properties.
but it was already in the dts
> for the FU740. dtbs_check was not able to pick up on this at the time
> but v2022.08 of dt-schema now can:
>
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie at e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected)
> From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
>
> The Linux driver does not use this property, but outside of the kernel
> this property may have users. Re-add the property and its "clocks"
> dependency.
>
Best regards,
Krzysztof
More information about the linux-riscv
mailing list