[PATCH] RISC-V: cpu_ops_spinwait.c should include head.h

Palmer Dabbelt palmer at dabbelt.com
Thu Aug 11 14:06:58 PDT 2022


On Wed, 13 Jul 2022 14:53:06 PDT (-0700), ben.dooks at sifive.com wrote:
> Running sparse shows cpu_ops_spinwait.c is missing two definitions
> found in head.h, so include it to stop the following warnings:
>
> arch/riscv/kernel/cpu_ops_spinwait.c:15:6: warning: symbol '__cpu_spinwait_stack_pointer' was not declared. Should it be static?
> arch/riscv/kernel/cpu_ops_spinwait.c:16:6: warning: symbol '__cpu_spinwait_task_pointer' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks at sifive.com>
> ---
>  arch/riscv/kernel/cpu_ops_spinwait.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/kernel/cpu_ops_spinwait.c b/arch/riscv/kernel/cpu_ops_spinwait.c
> index 346847f6c41c..c662a7cf10a4 100644
> --- a/arch/riscv/kernel/cpu_ops_spinwait.c
> +++ b/arch/riscv/kernel/cpu_ops_spinwait.c
> @@ -11,6 +11,8 @@
>  #include <asm/sbi.h>
>  #include <asm/smp.h>
>
> +#include "head.h"
> +
>  const struct cpu_operations cpu_ops_spinwait;
>  void *__cpu_spinwait_stack_pointer[NR_CPUS] __section(".data");
>  void *__cpu_spinwait_task_pointer[NR_CPUS] __section(".data");

Thanks, this is on for-next.



More information about the linux-riscv mailing list