[PATCH] riscv: Fix compilation warning

Damien Le Moal Damien.LeMoal at wdc.com
Wed Sep 16 00:55:00 EDT 2020


On Tue, 2020-09-15 at 21:52 -0700, Atish Patra wrote:
> On Tue, Sep 15, 2020 at 6:29 PM Damien Le Moal <Damien.LeMoal at wdc.com> wrote:
> > On 2020/09/16 4:44, Atish Patra wrote:
> > > On Tue, Sep 15, 2020 at 2:16 AM Damien Le Moal <damien.lemoal at wdc.com> wrote:
> > > > Move the declaration of pt_ops under "#ifdef iCONFIG_MMU" to avoid the
> > > > compilation warning:
> > > > 
> > > > arch/riscv/mm/init.c:44:28: warning: ‘pt_ops’ defined but not used
> > > > [-Wunused-variable]
> > > >    44 | static struct pt_alloc_ops pt_ops;
> > > >       |                            ^~~~~~
> > > > 
> > > > with NO MMU builds (e.g. nommu_k210_defconfig).
> > > > 
> > > 
> > > Thanks for the fix. pt_ops was added as a part of EFI series.
> > > I am planning to send v8 to include some more generic EFI changes.
> > > 
> > > Do you mind if I just include this fix in my series ?
> > 
> > Please feel free to integrate/squash this change in your series. No need for a
> > separate patch for just that. But: If your EFI series is not final, what is it
> > doing on the for-next branch ???
> > 
> > Palmer,
> > 
> > What is going on here ? If Atish V7 series has problems and is not final, why is
> > it already in for-next ?
> > 
> 
> UEFI support is going through a shared tree between UEFI & RISC-V. The
> v7 was supposed to be the final version but
> there were few patches in generic EFI code last week and Ard suggested
> to rebase the RISC-V UEFI series on top of it.
> Here is the thread.
> https://www.spinics.net/lists/linux-efi/msg20272.html
> 
> That's why I am planning to send another series with few other improvements.

OK. Thanks for the clarification.

-- 
Damien Le Moal
Western Digital Research


More information about the linux-riscv mailing list