[PATCH for-next] riscv/mm/fault: Fix inline placement in vmalloc_fault() declaration

Palmer Dabbelt palmer at dabbelt.com
Tue Sep 8 23:14:29 EDT 2020


On Fri, 04 Sep 2020 22:52:52 PDT (-0700), penberg at kernel.org wrote:
> The "inline" keyword is in the wrong place in vmalloc_fault()
> declaration:
>
>>> arch/riscv/mm/fault.c:56:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
>       56 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
>          | ^~~~~~
>
> Fix that up.
>
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Pekka Enberg <penberg at kernel.org>
> ---
>  arch/riscv/mm/fault.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
> index a23eaf5ce95c..a173432ccf82 100644
> --- a/arch/riscv/mm/fault.c
> +++ b/arch/riscv/mm/fault.c
> @@ -78,7 +78,7 @@ static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code
>  	no_context(regs, addr);
>  }
>
> -static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
> +static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
>  {
>  	pgd_t *pgd, *pgd_k;
>  	pud_t *pud, *pud_k;

Thanks, this is on for-next.



More information about the linux-riscv mailing list