[PATCH v21 14/14] arm64: dts: qcom: kaanapali-mtp-camera-s5kjn5: Add DT overlay

[Hangxiang Ma]

On 10/12/2026 2:57 PM, sashiko-bot at kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] dts: qcom: missing vddm-supply in s5kjn5 camera node
> --
> 
> commit c1df83521b79d78bdf83d4c496be4b0e82a9f05c
> Author: Hangxiang Ma <hangxiang.ma at oss.qualcomm.com>
> 
> arm64: dts: qcom: kaanapali-mtp-camera-s5kjn5: Add DT overlay
> 
> This commit enables the S5KJN5 image sensor via CCI on the Kaanapali MTP
> board. It adds a device tree overlay for the camera module connected to
> the CSIPHY2 interface in four lane mode.
> 
>> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp-camera-s5kjn5.dtso b/arch/arm64/boot/dts/qcom/kaanapali-mtp-camera-s5kjn5.dtso
>> new file mode 100644
>> index 0000000000000..d0e39855e0e62
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp-camera-s5kjn5.dtso
> [ ... ]
>> +&cci0_i2c1 {
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>> +
>> +	camera at 10 {
>> +		compatible = "samsung,s5kjn5";
>> +		reg = <0x10>;
>> +
>> +		reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&cam_mclk2_default &cam_reset2_default>;
>> +
>> +		clocks = <&cambistmclkcc CAM_BIST_MCLK_CC_MCLK2_CLK>;
>> +		assigned-clocks = <&cambistmclkcc CAM_BIST_MCLK_CC_MCLK2_CLK>;
>> +		assigned-clock-rates = <19200000>;
>> +
>> +		vddio-supply = <&vreg_l4n_1p8>;
>> +		vddd-supply = <&vreg_l1m_1p0>;
>> +		vdda-supply = <&vreg_l4m_2p2>;
>> +		vddio1p2-supply = <&vreg_l2n_1p2>;
>> +		afvdd-supply = <&vreg_l7m_2p8>;
> 
> [Severity: High]
> Does this device tree node omit the vddm-supply property?
> 
> Looking at the s5kjn5 driver in drivers/media/i2c/s5kjn5.c, it
> unconditionally requires the "vddm" regulator during probe:
> 
> static const char * const s5kjn5_supply_names[] = {
> 	"vddio",
> 	"vddd",
> 	"vddm",
> 	"vdda",
> 	"vddio1p2",
> 	"afvdd",
> };
> 
> Missing this property in the DT overlay will cause the driver probe to
> fail with -ENODEV, or if the regulator core substitutes a dummy regulator,
> the physical MIPI PHY power domain may remain unpowered, causing the sensor
> to fail to stream.
> 
>> +
>> +		port {
>> +			s5kjn5_out_ep: endpoint {
>> +				data-lanes = <1 2 3 4>;
>> +				link-frequencies = /bits/ 64 <1248000000>;
>> +				remote-endpoint = <&csiphy2_in_ep>;
>> +			};
>> +		};
>> +	};
>> +};
> 

vddm is an optional power supply and on this JN5 daughter card we don't 
this power rail.

---
Best Regards,
Hangxiang