[PATCH v3 3/3] phy: tegra: Add support for Tegra238 XUSB pad controller
Jon Hunter
jonathanh at nvidia.com
Thu Oct 8 05:09:28 PDT 2026
On 07/10/2026 17:27, Jon Hunter wrote:
>
> On 07/10/2026 16:20, Manivannan Sadhasivam wrote:
>> On Wed, Oct 07, 2026 at 03:44:43PM +0100, Jon Hunter wrote:
>>> Add support for the Tegra238 XUSB pad controller by populating the
>>> Tegra238 specific SoC data for the controller. The Tegra238 has three
>>> USB2 and USB3 ports, uses the same port ops as Tegra186 and has the
>>> same supplies as Tegra194. Due to the dependencies the Tegra238 device
>>> has on the Tegra186 port ops and Tegra194 supplies, drop the compile
>>> time guards around these structures.
>>>
>>> Signed-off-by: Jon Hunter <jonathanh at nvidia.com>
>>> ---
>>> drivers/phy/tegra/Makefile | 1 +
>>> drivers/phy/tegra/xusb-tegra186.c | 29 +++++++++++++++++++++++------
>>> drivers/phy/tegra/xusb.c | 6 ++++++
>>> drivers/phy/tegra/xusb.h | 3 +++
>>> 4 files changed, 33 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/phy/tegra/Makefile b/drivers/phy/tegra/Makefile
>>> index f5ed9582d80b..018a4cab2b40 100644
>>> --- a/drivers/phy/tegra/Makefile
>>> +++ b/drivers/phy/tegra/Makefile
>>> @@ -8,6 +8,7 @@ phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_210_SOC) += xusb-tegra210.o
>>> phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_186_SOC) += xusb-tegra186.o
>>> phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_194_SOC) += xusb-tegra186.o
>>> phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_234_SOC) += xusb-tegra186.o
>>> +phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_238_SOC) += xusb-tegra186.o
>>> phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_264_SOC) += xusb-tegra186.o
>>
>> This is just a mess. As a followup patch, could you please please switch to
>> generic ARCH_TEGRA Kconfig option as done in this commit, 6b5e2f70a95c
>> ("PCI: dwc: tegra194: Broaden architecture dependency")?
>
> Yes that would be a good idea and yes I can do that as a follow-up.
I did see the latest sashiko warning:
"Does this cause missing declaration warnings (-Wmissing-declarations or
-Wmissing-prototypes)".
I am not seeing any warnings but I can also address that in the
follow-up.
Jon
--
nvpublic
More information about the linux-phy
mailing list