[PATCH v3 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema
Vijay Kumar Tumati
vijay.tumati at oss.qualcomm.com
Tue Mar 3 15:50:02 PST 2026
On 3/3/2026 3:26 PM, Bryan O'Donoghue wrote:
> On 03/03/2026 23:17, Vijay Kumar Tumati wrote:
>> Sorry, I do not know about videocc.
>
> I think Iris does those itself see:
>
> iris: video-codec at aa00000 {
> compatible = "qcom,x1e80100-iris",
> "qcom,sm8550-iris";
>
> reg = <0 0x0aa00000 0 0xf0000>;
> interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>
> power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>,
> <&videocc VIDEO_CC_MVS0_GDSC>,
> <&rpmhpd RPMHPD_MXC>,
> <&rpmhpd RPMHPD_MMCX>;
> power-domain-names = "venus",
> "vcodec0",
> "mxc",
> "mmcx";
>
> Still not getting an especially clear picture on what _levels_ you are
> proposing here for MXA - here are the three opps we have for the PHY.
>
> Sorry I don't get how turbo is coming into this ..
Sure, I was just giving an example. I haven't looked a lot into the
IPCAT / clock corners of this target particularly. Someone needs to
check the clock plan, understand which PHYs require which power domains
and add that in the following OPP table and as for scaling you can use
the same RPMH levels for all those power domains. Btw, if you had
defined the below OPP table for TOP GDSC, I think that is wrong. It only
has two perf states (on and off) and doesn't need OPP scaling. If you
look at the Iris driver, they link only the mxc and mmcx power domains
to the OPP table using 'PD_FLAG_REQUIRED_OPP, not the GDSCs.
>
> + csiphy_opp_table: opp-table-csiphy {
> + compatible = "operating-points-v2";
> +
> + opp-300000000 {
> + opp-hz = /bits/ 64 <300000000>;
> + required-opps = <&rpmhpd_opp_low_svs_d1>;
> + };
> +
> + opp-400000000 {
> + opp-hz = /bits/ 64 <400000000>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> + };
> +
> + opp-480000000 {
> + opp-hz = /bits/ 64 <480000000>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> + };
> + };
>
> ---
> bod
Thanks,
Vijay.
More information about the linux-phy
mailing list