[PATCH 09/11] phy: renesas: phy-rcar-gen3-usb2: Fix devm action registration for disabled VBUS regulator
Claudiu Beznea
claudiu.beznea at tuxon.dev
Mon Jun 15 02:37:06 PDT 2026
Hi, Biju,
On 6/12/26 17:30, Biju wrote:
> From: Biju Das <biju.das.jz at bp.renesas.com>
>
> devm_regulator_get_exclusive() initialises the regulator with
> enable_count = 1, requiring the consumer to disable it before release.
>
> Previously, the devm disable action was only registered when the
> regulator was explicitly enabled, causing the cleanup path to skip
> decrementing enable_count on device removal when the regulator was
> left disabled.
>
> Fix this by always registering the devm disable action when the regulator
> is enabled (checked via regulator_is_enabled()), covering both the
> explicitly-enabled case and the initial state set by
> devm_regulator_get_exclusive().
>
> This fixes WARN_ON enable count during regulator release.
>
> Fixes: 24843404efe4 ("phy: renesas: phy-rcar-gen3-usb2: Control VBUS for RZ/G2L SoCs")
> Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
The approach in this patch don't solve the problem, at least on RZ/G3S. See [1]
for logs.
I applied this patch on next-20260610:
git log --oneline -2
afe09f11d549 (HEAD) phy: renesas: phy-rcar-gen3-usb2: Fix devm action
registration for disabled VBUS regulator
abe651837cb3 (tag: next-20260610, linux-next/master) Add linux-next specific
files for 20260610
[1]
https://github.com/claudiubeznea/logs/blob/2f1bab20407dfe6031385819ffeabfc4eac772bd/logs
More information about the linux-phy
mailing list