[PATCH v3 1/4] dt-bindings: phy: motorola,cpcap-usb: add chrg_det interrupt
Conor Dooley
conor at kernel.org
Mon Jul 6 10:14:56 PDT 2026
On Sun, Jul 05, 2026 at 01:11:02PM +0300, Ivaylo Dimitrov wrote:
> The CPCAP USB PHY driver uses the CPCAP charger detection interrupt
> for DCP detection.
This is not currently true, the driver does not look for this interrupt
at the time of this patch.
> Update the binding and example DTS to use the corresponding
> "chrg_det" interrupt name.
Sounds to me like this new interrupt is optional, since until now it has
not been needed? The patch however makes it mandatory. I think your
driver patch also makes it mandatory, which will break older
devicetrees.
What makes this ABI break okay?
Thanks,
Conor.
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75 at gmail.com>
> ---
> .../devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml
> index 0febd04a61f4..523a8f8480d0 100644
> --- a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml
> @@ -30,6 +30,7 @@ properties:
> - description: se1 interrupt
> - description: dm interrupt
> - description: dp interrupt
> + - description: charger detection interrupt
>
> interrupt-names:
> description: Interrupt names
> @@ -43,6 +44,7 @@ properties:
> - const: se1
> - const: dm
> - const: dp
> + - const: chrg_det
>
> io-channels:
> description: IIO ADC channels used by the USB PHY
> @@ -91,10 +93,10 @@ examples:
> interrupts-extended = <
> &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0
> &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0
> - &cpcap 48 1
> + &cpcap 48 1 &cpcap 13 0
> >;
> interrupt-names = "id_ground", "id_float", "se0conn", "vbusvld",
> - "sessvld", "sessend", "se1", "dm", "dp";
> + "sessvld", "sessend", "se1", "dm", "dp", "chrg_det";
> io-channels = <&cpcap_adc 2>, <&cpcap_adc 7>;
> io-channel-names = "vbus", "id";
> vusb-supply = <&vusb>;
> --
> 2.39.5
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-phy/attachments/20260706/b951c85a/attachment.sig>
More information about the linux-phy
mailing list