[PATCH V1 4/4] phy: qcom-qmp-ufs: read max-microamp values from device tree
Mark Brown
broonie at kernel.org
Wed Aug 6 09:51:04 PDT 2025
On Wed, Aug 06, 2025 at 05:58:30PM +0200, Konrad Dybcio wrote:
> On 8/6/25 5:43 PM, Nitin Rawat wrote:
> > Add support in QMP PHY driver to read optional vdda-phy-max-microamp
> > and vdda-pll-max-microamp properties from the device tree.
> > These properties define the expected maximum current (in microamps) for
> > each supply. The driver uses this information to configure regulators
> > more accurately and ensure they operate in the correct mode based on
> > client load requirements.
> > If the property is not present, the driver defaults load to
> > `QMP_VREG_UNUSED`.
> do you think having this in regulator core would make sense?
I'm not clear why the driver is trying to do this at all, the driver is
AFAICT making no other effort to manage the load at all. We already
impose any constraints that are defined for a regulator while initially
parsing them so it's not clear to me what this is supposed to
accomplish, and it'll be broken if the supply is ever shared since it'll
set the load from this individual consumer to the maximum that's
permitted for the regulator as a whole.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-phy/attachments/20250806/f90e05b6/attachment.sig>
More information about the linux-phy
mailing list