[PATCH v1 1/5] dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC
Rob Herring
robh at kernel.org
Thu Sep 21 11:38:50 PDT 2023
On Wed, Sep 20, 2023 at 07:25:08PM +0530, Mrinmay Sarkar wrote:
> Add devicetree bindings support for SA8775P SoC.
> Define reg and interrupt per platform.
>
> Signed-off-by: Mrinmay Sarkar <quic_msarkar at quicinc.com>
> ---
> .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 130 +++++++++++++++++----
> 1 file changed, 108 insertions(+), 22 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> index a223ce0..e860e8f 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> @@ -13,6 +13,7 @@ properties:
> compatible:
> oneOf:
> - enum:
> + - qcom,sa8775p-pcie-ep
> - qcom,sdx55-pcie-ep
> - qcom,sm8450-pcie-ep
> - items:
> @@ -20,29 +21,19 @@ properties:
> - const: qcom,sdx55-pcie-ep
>
> reg:
> - items:
> - - description: Qualcomm-specific PARF configuration registers
> - - description: DesignWare PCIe registers
> - - description: External local bus interface registers
> - - description: Address Translation Unit (ATU) registers
> - - description: Memory region used to map remote RC address space
> - - description: BAR memory region
> + minItems: 6
> + maxItems: 7
>
> reg-names:
> - items:
> - - const: parf
> - - const: dbi
> - - const: elbi
> - - const: atu
> - - const: addr_space
> - - const: mmio
> + minItems: 6
> + maxItems: 7
Don't move these into if/then schemas. Then we are duplicating the
names, and there is no reason to keep them aligned for new compatibles.
Rob
More information about the linux-phy
mailing list