[PATCH 3/3] phy: mapphone-mdm6600: Fix pinctrl_pm handling for sleep pins

Tony Lindgren tony at atomide.com
Tue Sep 12 21:59:13 PDT 2023


* Sebastian Reichel <sebastian.reichel at collabora.com> [230912 15:14]:
> Apparently phy_power_off is not called on device removal, so I
> understand the need to setup sleep pins in phy_mdm6600_device_power_off()
> in addition to the exsting setup in phy_mdm6600_power_off().
>
> But I'm a bit confused about the change required in probe(), since
> phy_mdm6600_power_on() selects the default state. I wouldn't expect
> any access before the phy is powered on? Anyways,

Maybe we should just set the sleep state in remove and leave it out of the
phy functions. If a separate state is needed for the phy_mdm6600_power_off(),
it could be the pinctrl idle state.

We need the reset pin in probe to get the modem started. The modem may
also be started in uart mode for firmware flashing depending on how the
gpio pins are set.

Regards,

Tony



More information about the linux-phy mailing list