[PATCH v2 3/3] phy: qcom-qmp-combo: use v6 registers in v6 regs layout

Konrad Dybcio konrad.dybcio at linaro.org
Mon Sep 11 14:21:08 PDT 2023


On 11.09.2023 23:17, Dmitry Baryshkov wrote:
> On Mon, 11 Sept 2023 at 23:42, Konrad Dybcio <konrad.dybcio at linaro.org> wrote:
>>
>> On 11.09.2023 22:38, Dmitry Baryshkov wrote:
>>> Make sure that we use only v6 registers in qmp_v6_usb3phy_regs_layout.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>> ---
>> [...]
>>
>>>  /* Only for QMP V6 PHY - USB3 have different offsets than V5 */
>> This comment becomes invalid
> 
> This actually rises the question, why was it called v6 in the first place?
if "it" == the qmpphy "v6"
	return "perhaps v5 was mostly ok but needed evolution";

Konrad
> 



More information about the linux-phy mailing list