[PATCH v4 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY
kernel test robot
lkp at intel.com
Wed Jun 14 08:10:51 PDT 2023
Hi Stanley,
kernel test robot noticed the following build warnings:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus robh/for-next linus/master v6.4-rc6 next-20230614]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Stanley-Chang/phy-realtek-usb-Add-driver-for-the-Realtek-SoC-USB-2-0-PHY/20230614-173349
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20230614092850.21460-2-stanley_chang%40realtek.com
patch subject: [PATCH v4 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230614/202306142352.e4eBd3HX-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
git fetch usb usb-testing
git checkout usb/usb-testing
b4 shazam https://lore.kernel.org/r/20230614092850.21460-2-stanley_chang@realtek.com
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/phy/realtek/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306142352.e4eBd3HX-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/phy/realtek/phy-rtk-usb2.c: In function 'parse_phy_data':
>> drivers/phy/realtek/phy-rtk-usb2.c:1229:25: warning: variable 'phy_cfg' set but not used [-Wunused-but-set-variable]
1229 | struct phy_cfg *phy_cfg;
| ^~~~~~~
vim +/phy_cfg +1229 drivers/phy/realtek/phy-rtk-usb2.c
1224
1225 static int parse_phy_data(struct rtk_phy *rtk_phy)
1226 {
1227 struct device *dev = rtk_phy->dev;
1228 struct device_node *node;
> 1229 struct phy_cfg *phy_cfg;
1230 struct phy_parameter *phy_parameter;
1231 int ret = 0;
1232 int index;
1233
1234 node = dev->of_node;
1235 phy_cfg = rtk_phy->phy_cfg;
1236
1237 rtk_phy->phy_parameter = devm_kzalloc(dev, sizeof(struct phy_parameter) *
1238 rtk_phy->num_phy, GFP_KERNEL);
1239 if (!rtk_phy->phy_parameter)
1240 return -ENOMEM;
1241
1242 for (index = 0; index < rtk_phy->num_phy; index++) {
1243 phy_parameter = &((struct phy_parameter *)rtk_phy->phy_parameter)[index];
1244
1245 phy_parameter->phy_reg.reg_wrap_vstatus = of_iomap(dev->of_node, 0);
1246 phy_parameter->phy_reg.reg_gusb2phyacc0 = of_iomap(dev->of_node, 1) + index;
1247 phy_parameter->phy_reg.vstatus_index = index;
1248
1249 if (of_property_read_bool(node, "realtek,inverse-hstx-sync-clock"))
1250 phy_parameter->inverse_hstx_sync_clock = true;
1251 else
1252 phy_parameter->inverse_hstx_sync_clock = false;
1253
1254 if (of_property_read_u32_index(node, "realtek,driving-level",
1255 index, &phy_parameter->driving_level))
1256 phy_parameter->driving_level = DEFAULT_DC_DRIVING_VALUE;
1257
1258 if (of_property_read_u32_index(node, "realtek,driving-compensate",
1259 index, &phy_parameter->driving_compensate))
1260 phy_parameter->driving_compensate = 0;
1261
1262 if (of_property_read_u32_index(node, "realtek,disconnection-compensate",
1263 index, &phy_parameter->disconnection_compensate))
1264 phy_parameter->disconnection_compensate = 0;
1265
1266 get_phy_data_by_efuse(rtk_phy, phy_parameter, index);
1267
1268 update_dc_driving_level(rtk_phy, phy_parameter);
1269
1270 update_hs_clk_select(rtk_phy, phy_parameter);
1271 }
1272
1273 return ret;
1274 }
1275
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the linux-phy
mailing list