[PATCHv1 3/5] dt-bindings: phy: rockchip: rk3588 has two reset lines
Rob Herring
robh at kernel.org
Tue Apr 18 13:41:36 PDT 2023
On Thu, Apr 13, 2023 at 08:23:43PM +0200, Sebastian Reichel wrote:
> The RK3588 has two reset lines for the combphy. One for the
> APB interface and one for the actual PHY.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.com>
> ---
> .../bindings/phy/phy-rockchip-naneng-combphy.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> index 9ae514fa7533..bac1aae07555 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> @@ -31,8 +31,13 @@ properties:
> - const: pipe
>
> resets:
> + minItems: 1
> + maxItems: 2
> +
> + reset-names:
> items:
> - - description: exclusive PHY reset line
> + - const: phy
> + - const: apb
This will fail on any existing users with single entry. You need to add
'minItems: 1' here.
It also fails if they didn't use 'phy' as the name, but names should be
defined.
Rob
More information about the linux-phy
mailing list