ARMADA espressobin SATA drive detection failure

[Shinichiro Kawasaki]

On Aug 13, 2022 / 02:15, Pali Rohár wrote:
> On Saturday 13 August 2022 00:02:37 Shinichiro Kawasaki wrote:
> > On Aug 12, 2022 / 15:55, Pali Rohár wrote:
> > > On Friday 12 August 2022 14:44:07 Pali Rohár wrote:
> > 
> > [...]
> > 
> > > > Probably this is SSD disk specific. I will try to prepare some kernel
> > > > changes to test if it changes something.
> > > 
> > > Could you please try following change and provide full dmesg log?
> > > First I need to know if issue is in SATA power on code or somewhere else.
> > 
> > My pleasure. I applied the patch to the kernel v5.18.16 and booted it from the
> > latest U-Boot. Here I attach console output taken from the mox-imager command.
> > It has all kernel messages as well as U-Boot console log. I find the message
> > from added dev_err():
> > 
> >   mvebu-a3700-comphy d0018300.phy: OK mvebu_a3700_comphy_sata_power_on() call
> > 
> > -- 
> > Shin'ichiro Kawasaki
> 
> Ok, so SATA does not work even when starting with original SMC
> implementation.
> 
> Could you please try another test change?
> 
> @@ -1102,6 +1142,9 @@ static int mvebu_a3700_comphy_reset(struct phy *phy)
>  	struct mvebu_a3700_comphy_lane *lane = phy_get_drvdata(phy);
>  	u16 mask, data;
>  
> +	dev_err(lane->dev, "IGNORING mvebu_a3700_comphy_reset() call\n");
> +	return;
> +
>  	dev_dbg(lane->dev, "resetting lane %d\n", lane->id);
>  
>  	/* COMPHY reset for internal logic */

Yes, I've applied the hunk above on top of the previous debug patch (I modified
'return' to 'return 0' to avoid a compile error). I attach the console log.

With this change,

- The added message "IGNORING mvebu_a3700_comphy_reset() call" was printed
  three times.
- The "ata1: SATA link down (SStatus 100 SControl 300)" message disappeared.
- My SSD was detected as /dev/sda.

-- 
Shin'ichiro Kawasaki
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: console_log_v5.18.16_debug_patch_2_new_firwmare.log
URL: <http://lists.infradead.org/pipermail/linux-phy/attachments/20220813/516bc0ac/attachment-0001.log>