[PATCH 2/2] phy: samsung-ufs: support exynosauto ufs phy driver
Chanho Park
chanho61.park at samsung.com
Mon Jul 5 16:57:50 PDT 2021
> > - samsung,exynos7-ufs-phy
> > + - samsung,exynosauto-ufs-phy
>
> I would prefer real product ID (taken from registers or vendor kernel),
> not a marketing name "Auto" because it's too generic, unspecified, too
> much as wildcard.
>
> If vendor kernel does not define name or product ID is also not specific,
> then it should include a version - so "autov9".
"samsung,exynosautov9-ufs-phy" can be a full name which can describe the SoC.
> I know that Exynos7 UFS did it but it was wrong. Headers should not define
> structures. What if a header needs to be included in different
> objects/units?
>
> This should be probably a separate file (C file). Something like we did
> for Exynos PMU (drivers/soc/samsung/exynos-pmu.h).
It makes sense to me. I'll move the structures from "phy-exynos7-ufs.h"
to "phy-exynos7-ufs.c" and create "phy-exynosautov9-ufs.c".
Best Regards,
Chanho Park
More information about the linux-phy
mailing list