[PATCH 2/2] phy: samsung-ufs: support exynosauto ufs phy driver

[Krzysztof Kozlowski]

On 05/07/2021 14:29, Krzysztof Kozlowski wrote:
> On 05/07/2021 12:23, Chanho Park wrote:
>> This patch adds to support phy-exynosauto-ufs driver for ExynosAuto v9
>> series SoCs. The patch adds "samsung,exynosauto-ufs-phy" compatible.
>> Unlike previous exynos ufs phy, the chip uses 0x50 offset as
>> PHY_TRSV_REG_CFG_OFFSET.
>>
>> Change-Id: I4ea333d4565af537c26a8876d1b27144eea3c3c6
>> Signed-off-by: Chanho Park <chanho61.park at samsung.com>
>> ---
>>  .../bindings/phy/samsung,ufs-phy.yaml         |  1 +
>>  drivers/phy/samsung/phy-exynosauto-ufs.h      | 70 +++++++++++++++++++
>>  drivers/phy/samsung/phy-samsung-ufs.c         |  3 +
>>  drivers/phy/samsung/phy-samsung-ufs.h         |  1 +
>>  4 files changed, 75 insertions(+)
>>  create mode 100644 drivers/phy/samsung/phy-exynosauto-ufs.h
>>
>> diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
>> index 636cc501b54f..8e13f8cec6a7 100644
>> --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
>> @@ -16,6 +16,7 @@ properties:
>>    compatible:
>>      enum:
>>        - samsung,exynos7-ufs-phy
>> +      - samsung,exynosauto-ufs-phy
> 
> I would prefer real product ID (taken from registers or vendor kernel),
> not a marketing name "Auto" because it's too generic, unspecified, too
> much as wildcard.
> 
> If vendor kernel does not define name or product ID is also not
> specific, then it should include a version - so "autov9".
> 

BTW, the previous Exynos Auto SoC was "Exynos Auto 8890", so it already
confuses naming with older designs. It would be actually good to compare
it with other recent Exynos PHYs (Exynos Auto 8890, generic Exynos9xxx
and Exynos980/990) because maybe it's not "Auto" at all.

Best regards,
Krzysztof