[PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Mar 26 19:06:18 EDT 2010


On Fri, Mar 26, 2010 at 06:57:07PM -0300, Marcelo Jimenez wrote:
> On Fri, Mar 26, 2010 at 15:18, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote:
> >>
> >>   I'd disagree in this case. Anybody will hardly grep for "mask:
> >> %s%s%s%s%s%sflags: %s%s%s%s%s%s".
> >
> > Well, I disagree on a matter of principle with you.  If you want to avoid
> > the line going over 80 columns, move the entire string onto the next line.
> > Then we can have the entire string intact _and_ we can have it fitting
> > within 80 columns.
> 
> This is no big deal. Also, I have already submitted the new patch and
> Valdis had a good point for egrep.

Sorry, I'm having stability issues with my MTA which inexplicably died
about 12 hours ago, presumably due to the level of crap flying around
the 'net nowadays.  This appears to be becoming a regular occurance in
the last week. ;(



More information about the linux-pcmcia mailing list