[PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

Marcelo Jimenez mroberto at cpti.cetuc.puc-rio.br
Fri Mar 26 17:57:07 EDT 2010


On Fri, Mar 26, 2010 at 15:18, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote:
>>
>>   I'd disagree in this case. Anybody will hardly grep for "mask:
>> %s%s%s%s%s%sflags: %s%s%s%s%s%s".
>
> Well, I disagree on a matter of principle with you.  If you want to avoid
> the line going over 80 columns, move the entire string onto the next line.
> Then we can have the entire string intact _and_ we can have it fitting
> within 80 columns.

This is no big deal. Also, I have already submitted the new patch and
Valdis had a good point for egrep.

Regards,
Marcelo.



More information about the linux-pcmcia mailing list