ss.h: unnecessary bit-field

Komuro komurojun-mbn at nifty.com
Sat Jul 17 09:03:52 EDT 2010


Hi,

include/pcmcia/ss.h

>	/* socket setup is done so resources should be able to be allocated.
>	 * Only if set to 1, calls to find_{io,mem}_region are handled, and
>	 * insertio events are actually managed by the PCMCIA layer.*/
>	u8				resource_setup_done:1;
>
>	/* It's old if resource setup is done using adjust_resource_info() */
>	u8				resource_setup_old:1;
>	u8				resource_setup_new:1;
>
>	u8				reserved:5;

meaningless bit-field?

>	/* 16-bit state: */
>	struct {
>		/* the PCMCIA card consists of two pseudo devices */
>		u8			has_pfc:1;
>
>		u8			reserved:7;
>	} pcmcia_state;

"struct pcmcia_state" is unnecessary?
it should be
    u8 has_pfc;







More information about the linux-pcmcia mailing list