[PATCH 06/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (char)

[Dominik Brodowski]

Hey,

On Mon, Oct 26, 2009 at 03:13:39PM +0100, Jiri Kosina wrote:
> On Sat, 24 Oct 2009, Dominik Brodowski wrote:
> 
> > Convert PCMCIA drivers to use the dynamic debug infrastructure, instead of
> > requiring manual settings of PCMCIA_DEBUG. Only some rare extra debug checks
> > in cm4000_cs.c cm4040_cs.c are now hidden behind a "#ifdef CM4000_DEBUG"
> > or "#ifdef CM4040_DEBUG".
> > 
> > Also, remove all usages of the CS_CHECK macro and replace them with proper
> > Linux style calling and return value checking. The extra error reporting may
> > be dropped, as the PCMCIA core already complains about any (non-driver-author)
> > errors.
> > 
> > CC: Harald Welte <laforge at gnumonks.org>
> > CC: Jiri Kosina <jkosina at suse.cz>
> > CC: David Sterba <dsterba at suse.cz>
> > Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>
> > ---
> >  drivers/char/pcmcia/cm4000_cs.c       |   69 ++++++++++++---------------------
> >  drivers/char/pcmcia/cm4040_cs.c       |   42 ++++++++------------
> >  drivers/char/pcmcia/ipwireless/main.c |   34 ++++------------
> >  drivers/char/pcmcia/synclink_cs.c     |   23 +++++------
> >  4 files changed, 61 insertions(+), 107 deletions(-)
> 
> For the ipwireless driver
> 
> 	Acked-by: Jiri Kosina <jkosina at suse.cz>

Thanks!

> I guess you are going to take it through your tree, right?

Yes, that's the plan.

Best,
	Dominik