[PATCH 1/3] Improve type handling in interrupt handlers

Jeff Garzik jgarzik at pobox.com
Fri Jan 18 17:54:23 EST 2008

Rusty Russell wrote:
> On Saturday 19 January 2008 07:41:41 Jeff Garzik wrote:
>> You should be using irq_handler_t for all these.
> Well, these are your drivers, but for mine I dislike the obfuscation.
> It's not like you can declare the function itself to be an irq_handler_t, so 
> it's a strange turd to drop in a driver.

The others need to be irq_handler_t because that's the precise type 
that's being used in each particularly situation.  Each time the code 
re-creates that definition creates a problem for future irq handler 
changes of any type, really.

As I noted, I've fixed all this crap already, and read through each one 
of those drivers.


More information about the linux-pcmcia mailing list