[PATCH] AT91RM9200 Compact Flash driver

[Dominik Brodowski]

Hi,

On Tue, Feb 21, 2006 at 12:56:52PM +0200, Andrew Victor wrote:
> --- linux-2.6.16-rc4.orig/drivers/pcmcia/at91_cf.c	Thu Jan  1 02:00:00 1970
> +++ linux-2.6.16-rc4/drivers/pcmcia/at91_cf.c	Tue Feb 21 12:19:18 2006
> @@ -0,0 +1,365 @@
> +/*
> + * at91_cf.c -- AT91 CompactFlash controller driver
> + *
> + * Copyright (C) 2005 David Brownell

Is this patch from David, or from you?

> +	(void) at91_set_A_periph(AT91_PIN_PC9, 0);	/* A25/CFRNW */
> +	(void) at91_set_A_periph(AT91_PIN_PC10, 0);	/* NCS4/CFCS */
> +	(void) at91_set_A_periph(AT91_PIN_PC11, 0);	/* NCS5/CFCE1 */
> +	(void) at91_set_A_periph(AT91_PIN_PC12, 0);	/* NCS6/CFCE2 */

Why do you add "(void)" here before the function call?

> +	/* nWAIT is _not_ a default setting */
> +	(void) at91_set_A_periph(AT91_PIN_PC6, 1);	/*  nWAIT */

Same here?


Other than that, it does look good from a first, quick glance at it.

	Dominik