[PATCH] pcmciautils: fix endless loop in dump_cis

Daniel Ritz daniel.ritz-ml at swissonline.ch
Sun Oct 23 16:43:26 EDT 2005


[PATCH] pcmciautils: fix endless loop in dump_cis

in case of an invalid tuple the current code loops endlessly...

Signed-off-by: Daniel Ritz <daniel.ritz at gmx.ch>

--- pcmciautils-010/debug/dump_cis.c~	2005-10-23 00:21:13.000000000 +0200
+++ pcmciautils-010/debug/dump_cis.c	2005-10-23 00:21:24.000000000 +0200
@@ -942,15 +942,13 @@
 			print_tuple(&tuple);
 
 		ret = pccard_parse_tuple(&tuple, &parse);
-		if (ret) {
+		if (ret)
 			printf("invalid tuple\n");
-			continue;
+		else {
+			print_parse(&tuple, &parse);
+			printf("\n");
 		}
 
-		print_parse(&tuple, &parse);
-
-		printf("\n");
-
 		ret = pcmcia_get_next_tuple(BIND_FN_ALL, &tuple);
 		if (ret)
 			break;



More information about the linux-pcmcia mailing list