[patches 2/5] pcmcia: request CIS via firmware interface

[Dominik Brodowski]

On Thu, Mar 03, 2005 at 03:16:57PM +0000, Matthew Wilcox wrote:
> On Wed, Mar 02, 2005 at 10:24:45PM +0100, Dominik Brodowski wrote:
> > +	  Some PCMCIA cards require an update Card Information Structure (CIS)
> 
> Tpyo -- "updated"
> 
> > +	int ret=-ENOMEM;
> > +        cisdump_t *cis;
> 
> spaces instead of tab
> 
> > +	if(request_firmware(&fw, path, &dev->dev) == 0) {
> 
> missing space after "if"

Thanks, fixed all of them.

> > +		if (fw->size >= CISTPL_MAX_CIS_SIZE)
> > +			goto release;
> > +
> > +		cis = kmalloc(sizeof(cisdump_t), GFP_KERNEL);
> 
> I think we prefer sizeof(*cis), right?

Do we?

Thanks,
	Dominik