[patches 2/5] pcmcia: request CIS via firmware interface

[Matthew Wilcox]

On Wed, Mar 02, 2005 at 10:24:45PM +0100, Dominik Brodowski wrote:
> +	  Some PCMCIA cards require an update Card Information Structure (CIS)

Tpyo -- "updated"

> +	int ret=-ENOMEM;
> +        cisdump_t *cis;

spaces instead of tab

> +	if(request_firmware(&fw, path, &dev->dev) == 0) {

missing space after "if"

> +		if (fw->size >= CISTPL_MAX_CIS_SIZE)
> +			goto release;
> +
> +		cis = kmalloc(sizeof(cisdump_t), GFP_KERNEL);

I think we prefer sizeof(*cis), right?

> +		if (!cis)
> +			goto release;
> +
> +		memset(cis, 0, sizeof(cisdump_t));

Could have used kcalloc instead, i guess ...

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain