PCMCIA stack reduction patch [Was: Re: Realtime Preemption, 2.6.12, Beginners Guide?]

Dominik Brodowski linux at dominikbrodowski.net
Tue Jul 12 11:37:08 EDT 2005


On Mon, Jul 11, 2005 at 10:19:14AM +0200, Steven Scholz wrote:
> Dominik,
> 
> >>-	pcmcia_device_query(p_dev);
> >>+	ret = pcmcia_device_query(p_dev);
> >>+	if (ret)
> >>+		goto err_put_module;
> >>
> >>	/*
> >>	 * Prevent this racing with a card insertion.
> >
> >We don't check the return value here for a reason.
> 
> 
> Do you mind telling us for which reason?

It is not uncommon that we cannot determine the information about the device
(and this is what pcmcia_device_query() does) at this moment. Nonetheless,
we want to keep this device registered, so that we can use pcmcia_requery()
(called from pcmcia_bus_rescan()) to update the information.

	Dominik



More information about the linux-pcmcia mailing list