PCMCIA stack reduction patch [Was: Re: Realtime Preemption, 2.6.12, Beginners Guide?]

[Steven Scholz]

Dominik,

>>this patch reduces the stack footprint of pcmcia_device_query() from 416 
>>bytes to 36 bytes. (patch only build-tested)
> 
> Applied and tested, but without the final hunk.
> 
>>@@ -856,7 +868,9 @@ static int bind_request(struct pcmcia_bu
>> rescan:
>> 	p_dev->cardmgr = p_drv;
>> 
>>-	pcmcia_device_query(p_dev);
>>+	ret = pcmcia_device_query(p_dev);
>>+	if (ret)
>>+		goto err_put_module;
>> 
>> 	/*
>> 	 * Prevent this racing with a card insertion.
> 
> We don't check the return value here for a reason.


Do you mind telling us for which reason? And maybe even add a comment to the 
source?

--
Steven