[RFC] pcmcia: export stored values in sysfs

Dominik Brodowski linux at dominikbrodowski.net
Sun Dec 11 16:22:58 EST 2005


Hi,

On Sun, Dec 11, 2005 at 08:35:47PM +0000, Russell King wrote:
> > diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c
> > index 8e33793..3546d37 100644
> > --- a/drivers/pcmcia/cs.c
> > +++ b/drivers/pcmcia/cs.c
> > @@ -453,11 +453,11 @@ static int socket_setup(struct pcmcia_so
> >  	}
> >  
> >  	if (status & SS_CARDBUS) {
> > +		skt->state |= SOCKET_CARDBUS;
> >  		if (!(skt->features & SS_CAP_CARDBUS)) {
> >  			cs_err(skt, "cardbus cards are not supported.\n");
> >  			return CS_BAD_TYPE;
> >  		}
> > -		skt->state |= SOCKET_CARDBUS;
> 
> If the card is not supported, we return an error, which will shut down
> the socket.  This in turn clears skt->state to a clean state, so this
> change is meaningless.

Thanks, removed that hunk from the patch.

	Dominik



More information about the linux-pcmcia mailing list