Yet More Patches

[Russell King]

On Tue, Mar 09, 2004 at 04:38:26PM -0500, Pavel Roskin wrote:
> On Mon, 8 Mar 2004, Russell King wrote:
> > For this to happen, it needs to be thoroughly tested, which means I
> > need to hear success reports.
> 
> I have tested it on Linux 2.6.4-rc2-bk5 (the latest snapshot).
> 
> One problem is that 01-debug.diff couldn't be applied to sa11xx_core.c
> cleanly.  Since I wasn't testing on ARM, I ignored the failure and applied
> the rest.

Hmm interesting - I'll look into that.

> After I booted the patched kernel, I tested the CVS Orinoco driver.  There
> was one error message:
> 
> orinoco_cs: Unknown symbol pcmcia_report_error

Hmm, I don't see a good reason to hide this function, although that is
the effect of Dominik's patch.  I don't think it's a good idea either,
and, as we're supposed to be in a stable series I'd prefer to not make
such gratuitous changes.  So... consider it re-exported.

> I'll fix orinoco_cs.c in CVS to use cs_error().  I hope it will be in the
> kernel soon, but I cannot promise that it will be there before
> 06-cardservices.diff is applied.

>From the comments in orinoco_cs, it appears that they wanted to keep 2.4
compatibility.  While that's a good thing, the reality is that over time
that's going to become progressively harder to achieve.

Though note what I said above - I'm not intending wide-ranging interface
changes without good reasons for making them.

(btw, the recent fixes to PCMCIA net drivers which I've recently done
also need to be considered for PCMCIA wireless drivers as well.  Plus,
there's also the ordering of netdev unregistration to be fixed...  We
shouldn't unregister the driver after we've released the PCMCIA
windows etc.  And note that under 2.6, unregistering a netdev
automatically downs the interface as well.)

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core