[PATCHv2] nvme-pci: fix stuck reset on concurrent DPC and HP

Christoph Hellwig hch at lst.de
Mon Mar 10 06:23:11 PDT 2025


On Fri, Mar 07, 2025 at 03:26:18PM -0800, Keith Busch wrote:
>  	struct request *abort_req;
>  	struct nvme_command cmd = { };
> +	struct pci_dev *pdev = to_pci_dev(dev->dev);
>  	u32 csts = readl(dev->bar + NVME_REG_CSTS);
>  	u8 opcode;
>  
> +	if (pci_dev_is_disconnected(pdev))
> +		nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_DELETING);

Can you add a comment here (based on the commit message) explaining the
logic here, as it is anything but obvious?

Otherwise this looks good to me.



More information about the Linux-nvme mailing list