[PATCH 3/3] nvme: enable retries for authentication commands

[Hannes Reinecke]

On 1/29/24 07:00, Christoph Hellwig wrote:
> On Sat, Jan 27, 2024 at 10:37:46AM +0100, hare at kernel.org wrote:
>> From: Hannes Reinecke <hare at suse.de>
>>
>> Authentication commands are normal NVMe commands, and as such
>> can return a status where NVME_SC_DNR is not set, indicating
>> that the command should be retried.
> 
> What command is not normal?
> 
Things like 'property set' or 'property get', which are used in eg
nvmf_reg_read() et al. They are used to retrieve or get register 
settings, and it's not quite clear if it's safe (or prudent) to retry them.

>> This patch enables retries by setting NVME_SUBMIT_RETRY for
>> __nvme_submit_sync_cmd().
> 
> I think what should go into the commit log is why the retries are
> desirable here, and not for other admin commands.
> 
Okay.

> Otherwise this looks good to me.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich