[PATCH 3/3] nvme: enable retries for authentication commands

Christoph Hellwig hch at lst.de
Sun Jan 28 22:00:05 PST 2024


On Sat, Jan 27, 2024 at 10:37:46AM +0100, hare at kernel.org wrote:
> From: Hannes Reinecke <hare at suse.de>
> 
> Authentication commands are normal NVMe commands, and as such
> can return a status where NVME_SC_DNR is not set, indicating
> that the command should be retried.

What command is not normal?

> This patch enables retries by setting NVME_SUBMIT_RETRY for
> __nvme_submit_sync_cmd().

I think what should go into the commit log is why the retries are
desirable here, and not for other admin commands.

Otherwise this looks good to me.



More information about the Linux-nvme mailing list