[PATCH 1/5] nvmet: Fix identify Namespace handling

Christoph Hellwig hch at lst.de
Wed Mar 15 06:35:08 PDT 2023


On Wed, Mar 15, 2023 at 07:59:35PM +0900, Damien Le Moal wrote:
> The identify command with cns set to NVME_ID_CNS_NS does not directly
> depend on the command set. The NVMe specifications is rather confusing
> here as it appears that this command only applies to the NVM command
> set. However, footnote 8 of Figure 273 in the NVMe 2.0 base
> specifications clearly state that this command applies to NVM command
> sets that support logical blocks, that is, NVM and ZNS. Both the NVM and
> ZNS command set specifications also list this identify as mandatory.
> 
> The command handling should thus not look at the csi field since it is
> defined as unused for this command. Given that we do not support the
> KV command set, simply remove the csi switch-case for that command
> handling and call directly nvmet_execute_identify_ns() in
> nvmet_execute_identify().

Yes, this CNS value pre-dates the addition of the CSI value,
and thus CSI should be ignored.




More information about the Linux-nvme mailing list