[PATCH 4/5] nvmet: relocate the cntlid_ida to the internal of subsystem

Christoph Hellwig hch at lst.de
Wed Dec 13 07:37:28 PST 2023


On Wed, Dec 13, 2023 at 08:59:26PM +0800, Guixin Liu wrote:
>> nvmet: Make cntlid globally unique
>>      We usually log the cntlid which is confusing in case
>> we have multiple subsystems each with it's own cntlid ida.
>> Instead make cntlid ida globally unique and log the initial
>> association.
>> "
>>
>> which seems reasonable.  If you have a reason for not making it unique,
>> it needs to be stated here so we can weight it against the original
>> reason for making the ids globally unique.
>
> Emm, I just change this per the NVMe spec, Sagi's comment is reasonable.

It's probably worth moving the above into a comment to explain what we're
doing here..



More information about the Linux-nvme mailing list